Not possible to write a custom matcher for undefined

[marchaos]

🐛 Bug Report

To Reproduce

When we define this custom matcher:

class CustomAnythingMatcher extends AsymmetricMatcher<any> {
    asymmetricMatch(other: unknown) {
        return true;
    }

    toString() {
        return 'Anything';
    }

    toAsymmetricMatcher() {
        return 'Anything';
    }
}
export const customAnything = (): CustomAnythingMatcher => new CustomAnythingMatcher();

and you attempt to use this like so

const fn = jest.fn();
fn(undefined);
expect(fn).toHaveBeenCalledWith(customAnything());

It doesn't pass. This is because when we get to JasmineUtils.eq(), where we are checking the expected vs actual arguments array, it passes in a hasKey implementation of hasDefinedKey. JasmineUtils.eq() invokes this block, which returns false in the case of above.

  if (keys(b, hasKey).length !== size) {
    return false;
  }

The main cause is the implementation of hasDefinedKey, which isn't really suitable for an arguments value list

function hasDefinedKey(obj, key) {
  return hasKey(obj, key) && obj[key] !== undefined;
}

Expected behavior

the internal jest code should delegate the equality check to the custom matcher.

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.