Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Bump JSDOM #12023

Closed
hgiesel opened this issue Nov 2, 2021 · 6 comments 路 Fixed by #12290
Closed

[Feature]: Bump JSDOM #12023

hgiesel opened this issue Nov 2, 2021 · 6 comments 路 Fixed by #12290

Comments

@hgiesel
Copy link

hgiesel commented Nov 2, 2021

馃殌 Feature Proposal

JSDOM is now up to 18.0.1 whereas jest-environment-jsdom uses 16.6.0. I suggest bumping JSDOM to the current version.

Motivation

JSDOM 18.0.1 has several bug fixes and speed improvements.

Example

No response

Pitch

Jest already features JSDOM.

@SimenB
Copy link
Member

SimenB commented Nov 2, 2021

Doing so is a breaking change, but we can do it for our next major

@SimenB SimenB added this to the Jest 28 milestone Nov 2, 2021
@mtsoltan
Copy link

Not sure if relevant now:
#12098 (comment)

@Smrtnyk
Copy link

Smrtnyk commented Dec 3, 2021

@SimenB
Copy link
Member

SimenB commented Feb 5, 2022

Not sure if relevant now: #12098 (comment)

Still relevant for everybody installing the environment 馃檪

@SimenB
Copy link
Member

SimenB commented Feb 10, 2022

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants