Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: ignoreProjects counterpart to selectProjects #12618

Closed
eliw00d opened this issue Mar 30, 2022 · 5 comments 路 Fixed by #12620
Closed

[Feature]: ignoreProjects counterpart to selectProjects #12618

eliw00d opened this issue Mar 30, 2022 · 5 comments 路 Fixed by #12620

Comments

@eliw00d
Copy link

eliw00d commented Mar 30, 2022

馃殌 Feature Proposal

Currently, selectProjects allows you to include projects by displayName. However, there is no to way exclude projects by displayName. So, adding ignoreProjects would allow you to exclude projects by displayName.

Motivation

In a large monorepo it is quite verbose to use selectProjects when you only need to exclude a small number of projects.

Example

--selectProjects A,B,D,E,F,H,I,J,K,L,M,N,O,P,Q,R,S,T,U,V,W,X,Z

versus

--ignoreProjects C,G,Y

Pitch

If there is an include there should also be an exclude.

Although I could probably get this to work with --projects and a glob, it would be nice to exclude them by displayName instead of path.

Also, as a bonus, they use the same number of characters. 馃槃

@F3n67u
Copy link
Contributor

F3n67u commented Mar 31, 2022

@eliw00d I'd like to implement this feature. do you think using selectProjects and ignoreProjects together make sense?

@eliw00d
Copy link
Author

eliw00d commented Mar 31, 2022

I don't see why not!

@SimenB
Copy link
Member

SimenB commented Apr 5, 2022

https://github.com/facebook/jest/releases/tag/v28.0.0-alpha.8

@eliw00d
Copy link
Author

eliw00d commented Apr 5, 2022

Insane turnaround! Thanks @F3n67u and @SimenB !

@github-actions
Copy link

github-actions bot commented May 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants