Switch Optimist with Minimalist -> Deprecation notice

[stephnr]

I was running through bin/jest.js and noticed that the Optimist plugin issued a deprecation notice and recommends changing to use minimist instead.

I would be willing to make this conversion going ahead 👍

[ide]

I imagine a PR would be appreciated if you want to contribute one when you have time.

[cpojer]

There is also nomnom which we have been using for https://github.com/facebook/jscodeshift

[mbrio]

If no one is working on this, I'd be willing to do the migration. I guess the question is what would be the best library. Optimist specifically mentions yargs as it's replacement which I believe is 100% compatible, is active, and has a large following. If the argument is that Optimist is deprecated and Jest should be using a non-deprecated library then yargs may be the better solution as there would be code changes if we use Minimist. If we are going to spend any time changing code then we'd probably be better off as @cpojer says and use what the other FB projects are using.

[cpojer]

@fkling what would you recommend? I remember we had this discussion around jscodeshift as well.

@mbrio it would be awesome if you could take this on! I'll try to merge #800 today, it probably makes sense to wait for that first :)

[mbrio]

Sounds good, I'll keep my ear out for this. Tomorrow may be hard for me, but I'll get to it this week.

[cpojer]

Alright, the refactor from #800 has now landed!

[cpojer]

I'm gonna close this because I honestly don't really care much about it. It works just fine. @DmitriiAbramov is thinking of redoing some stuff here, so maybe he can consider to replace this module eventually.

[aaronabramov]

👍
I think for this change we need to have at least a small design doc that will list the requirements for CLI, and based on this we can decide which library we should use

[cpojer]

I agree. The deprecation notice itself is not enough for anyone at FB to spend time working on this.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.