Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-docblock] Do not extract /* these */ comments #5650

Closed
azz opened this issue Feb 24, 2018 · 10 comments
Closed

[jest-docblock] Do not extract /* these */ comments #5650

azz opened this issue Feb 24, 2018 · 10 comments
Labels

Comments

@azz
Copy link
Contributor

azz commented Feb 24, 2018

Do you want to request a feature or report a bug?

Bug

What is the expected behavior?

expect(
  require('jest-docblock').extract(`
    /* a */
    /** b */
  `)
).toEqual(`/** b */`)

What is the current behavior?

It returns the non-docblock /* a */.

Fixing this could be considered a breaking change, so perhaps adding an option {strict:true} is preferable?

@SimenB
Copy link
Member

SimenB commented Feb 24, 2018

Feels like a bug to me, not necessarily breaking. @cpojer?

@sygint
Copy link

sygint commented Apr 6, 2018

If anyone approves of a solution, I can write this

@SimenB
Copy link
Member

SimenB commented Apr 7, 2018

@cpojer thoughts here?

@sygint
Copy link

sygint commented May 16, 2018

anything? this still seems to be affecting other libraries like Prettier

@edvinerikson
Copy link
Contributor

This was the reason #2005

@SimenB
Copy link
Member

SimenB commented May 16, 2018

Seeing as @providesModule is out (#6104), maybe we can fix this?

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 25, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants