Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: test.only does not group skipped tests anymore #8969

Closed
tarjei opened this issue Sep 20, 2019 · 19 comments
Closed

Regression: test.only does not group skipped tests anymore #8969

tarjei opened this issue Sep 20, 2019 · 19 comments

Comments

@tarjei
Copy link

tarjei commented Sep 20, 2019

馃悰 Bug Report

According to #2593 a .only on a test should remove the other tests from the test output.

To Reproduce

Steps to reproduce the behavior:

  1. Choose a testcase
  2. Annotate it with .only:
it.only("should print only one test", async () => {
await Promise.resolve(true)
}
  1. Run jest

Expected behavior

Only the single test should be in the output.

Link to repl or repo (highly encouraged)

https://repl.it/repls/NavajowhiteRemoteOutlier

envinfo

Ubuntu 18.04 , Node 10.16.3.

@thymikee
Copy link
Collaborator

This behavior was changed in v23 if I remember correctly, so it works as expected.

@sheerun
Copy link

sheerun commented Nov 5, 2019

@thymikee I'm using 24.9.0 and it still shows skipped tests. Can you reopen?

@thymikee
Copy link
Collaborator

thymikee commented Nov 5, 2019

@sheerun If you have a minimal repro case we can download, please create a new issue and post there.

@sheerun
Copy link

sheerun commented Nov 5, 2019

@thymikee I don't get it. Author of this issue already posted issue and minimal repro that you can even run in browser

@thymikee
Copy link
Collaborator

thymikee commented Nov 5, 2019

It was changed with this PR: #8038 to fix #7999.
@SimenB do you think we should bring back grouping skipped tests and leave todo as is now?

@sheerun
Copy link

sheerun commented Nov 5, 2019

This issue happens in 24.9.0 which has been released in August while this PR has been merged in March.. It is a regression

@sheerun
Copy link

sheerun commented Nov 5, 2019

(it's happening not in verbose mode, but normal mode)

@sheerun
Copy link

sheerun commented Nov 5, 2019

Also my use case: I have 120 tests and have .only on just one of them. When running jest with default settings (also when using --watchAll), all 119 skipped tests are printed, instead of just one that interests me.

@thymikee thymikee changed the title .only does not hide skipped tests Regression: test.only does not group skipped tests anymore Nov 5, 2019
@thymikee
Copy link
Collaborator

thymikee commented Nov 5, 2019

Let's reopen and discuss. I think changing the behavior for test.skip in #8038 was not necessary, also not requested in #7999. It was also an oversight from my side as a reviewer.

@sheerun
Copy link

sheerun commented Jan 14, 2020

Any chance to revert this change?

@nunofgs
Copy link

nunofgs commented Mar 11, 2020

Any news here? just hit this as well. Very annoying.

@tralston
Copy link

I am seeing the same issue here, when I focus on a few tests out of dozens. Any updates?

@sheerun
Copy link

sheerun commented Nov 19, 2020

Happy yearversary of this issue everyone...

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 25, 2022
@4ekki
Copy link

4ekki commented Feb 25, 2022

Still actual in 27.4.7

@github-actions github-actions bot removed the Stale label Feb 25, 2022
@lucasrmendonca
Copy link

Still an issue in 29.3.0

Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants