Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM audit failure #9648

Closed
ghost opened this issue Mar 9, 2020 · 5 comments
Closed

NPM audit failure #9648

ghost opened this issue Mar 9, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Mar 9, 2020

Just alerting you to the fact that I'm getting an npm audit failure regarding two third party dependencies of Jest (acorn and kind-of). These are flagged as containing potential vulnerabilities, specifically "Validation Bypass" and "Regular Expression Denial of Service".

@pratiksawant10
Copy link

I am facing similar issues. Any updates on fixing this error?

@mattdarveniza
Copy link

Yep, this will require an update of jest-environment-doms version of jsdom from 15 -> 16, which is why npm audit can't auto-fix. JSDom 16 requires a minimum node version of 10, while Jest's current min version is v8. Unless jsdom introduces a bug fix patch in version 15, this may be a bigger change than expected.

Given all of that, I suspect this may take a while longer than most other packages. The good news is that unless you're running jest on a public facing server (why), this shouldn't be a concerning vulnerability.

@pratiksawant10
Copy link

@mattdarveniza Looks like the issue is currently being address, have a look at this - #9643

@SimenB
Copy link
Member

SimenB commented Mar 10, 2020

Duplicate of #9643

@SimenB SimenB marked this as a duplicate of #9643 Mar 10, 2020
@SimenB SimenB closed this as completed Mar 10, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants