Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_positions_options: Column state doesn't exist #141

Closed
fouslim opened this issue Jan 31, 2022 · 1 comment
Closed

get_positions_options: Column state doesn't exist #141

fouslim opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
api change bug Something isn't working
Projects

Comments

@fouslim
Copy link

fouslim commented Jan 31, 2022

Hi @JestonBlu.

I got a similar error as #139 when calling get_positions_options, this time column state is missing.
The fix I found was to modify line 67 of get_positions_options.R:
options <- dplyr::inner_join(options, option_market_data, by = "option")
to
options <- dplyr::inner_join(options, option_market_data, by = c("option", "state"))

thanks

@JestonBlu JestonBlu self-assigned this Jan 31, 2022
@JestonBlu JestonBlu added api change bug Something isn't working labels Jan 31, 2022
@JestonBlu JestonBlu added this to To Do in 1.x via automation Jan 31, 2022
@JestonBlu
Copy link
Owner

@fouslim thanks, ill push a fix shortly. It looks like the API changed to add some additional fields that are common and are being renamed when I join. I must have missed this one or it changed again after i fixed it. Ill push a fix to github tonight and a patch to CRAN in a week or so in case there are any other issues.

JestonBlu added a commit that referenced this issue Feb 1, 2022
(GH-141) get_positions_options: Column `state` doesn't exist
1.x automation moved this from To Do to Completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change bug Something isn't working
Projects
1.x
  
Completed
Development

No branches or pull requests

2 participants