Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Dropdown styling and icons #682

Closed
GeorgeBellTMH opened this issue Feb 4, 2021 · 4 comments
Closed

Mobile Dropdown styling and icons #682

GeorgeBellTMH opened this issue Feb 4, 2021 · 4 comments
Assignees

Comments

@GeorgeBellTMH
Copy link
Contributor

image

@mmacedom so can you:

  1. get the gear icon to be centered and probably remove a bit of the padding...
  2. pick some relevant icons for the dropdown items
  3. determine if there is any other styling we should do? (not sure if this should be orange, or maybe transparent, or with a border?
  4. for events make sure all the items show up without the scrolling
@mmacedom
Copy link
Collaborator

mmacedom commented Feb 8, 2021

@GeorgeBellTMH Is this on the dashboard? I just pulled from master and I'm not seeing these drop downs. Let me know. Thx

@GeorgeBellTMH
Copy link
Contributor Author

Ya, I think maybe there is some logic problem....it only shows up ifMobile...but it should probably show up even if it's desktop....just <720px...

@mmacedom
Copy link
Collaborator

mmacedom commented Feb 8, 2021

@GeorgeBellTMH weird. I'm not even seeing it on mobile. Once you merge my PR, I'll pull again and try again.

@mmacedom
Copy link
Collaborator

mmacedom commented Feb 9, 2021

@GeorgeBellTMH I fixed these issues. Tried different colours for the button and it seemed like the orange seems to work best. Let me know what you think. PS: the cog svg needs to be crop so that the icon is totally centred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants