Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpandChild suggestions #16

Closed
Zazo032 opened this issue Jun 26, 2020 · 3 comments
Closed

ExpandChild suggestions #16

Zazo032 opened this issue Jun 26, 2020 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Zazo032
Copy link

Zazo032 commented Jun 26, 2020

Currently, if you set expandArrowStyle to ExpandArrowStyle.text, a Tootltip is still shown on long press (with the same text as the button). Also, tooltipMessage is forced to upper case on the button: https://github.com/jesusrp98/expand_widget/blob/master/lib/src/expand_arrow.dart#L109, so setting collapsedHint to Test will result in a button with TEST text and a Test Tooltip.

@jesusrp98 jesusrp98 self-assigned this Sep 16, 2020
@jesusrp98 jesusrp98 added bug Something isn't working enhancement New feature or request labels Sep 16, 2020
@jesusrp98
Copy link
Owner

I was aware of this issue, and I think it's about time this is fixed (sorry for the delay).

The tooltip should not be visible when expandArrowStyle is set to ExpandArrowStyle.text. On the other hand, I think it's OK to force the text to be upper case inside the button.

What do you think?

@Zazo032
Copy link
Author

Zazo032 commented Sep 16, 2020

For better customization, I think it'd better be an option to not force button text to be upper case. In our case, we're using it as a label button (e.g. "See more"), that expands a list of services, so per design, we need it to be lowercase. The tooltip may be fixed by detecting if it's either a mouse or touch event,.

@jesusrp98
Copy link
Owner

OK I see. I think adding a new option to make text capital would be great.

Planning to implement it over the next few days.
Also, the tooltip showing with ExpandArrowStyle.text or ExpandArrowStyle.both should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants