Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being able to create a ComposePanel with vsync disabled #4870

Closed
MohamedRejeb opened this issue May 24, 2024 · 0 comments · Fixed by JetBrains/compose-multiplatform-core#1377
Closed

Being able to create a ComposePanel with vsync disabled #4870

MohamedRejeb opened this issue May 24, 2024 · 0 comments · Fixed by JetBrains/compose-multiplatform-core#1377
Assignees
@elijah-semyonov
Labels
desktop p:high High priority performance rendering Low level rendering

Comments

@MohamedRejeb
Copy link

Hi,
I've been discussing the current latency issue with @igordmn , especially when working with inputs. One of the possible solutions to reduce latency is to disable vsync, but it's not a good option because it will make the program slower.
So Igor suggested having 2 panels one for ui (with vsync) and one for drawing (without vsync).
We will need the ability to configure ComposePanel(skiaLayerProperties = SkiaLayerProperties(isVsyncEnabled = false))

Thanks!
@igordmn igordmn added p:high High priority desktop rendering Low level rendering and removed submitted labels May 24, 2024
@elijah-semyonov elijah-semyonov mentioned this issue May 28, 2024
Merged
elijah-semyonov added a commit to JetBrains/compose-multiplatform-core that referenced this issue Jun 14, 2024
@elijah-semyonov @MatkovIvan
Add constructor with RenderSettings to ComposePanel (#1377)
03d732f 
Fixes JetBrains/compose-multiplatform#4870

## Release Notes

### Features - Desktop
- Add constructor with `reducePresentationLatency` to `ComposePanel`.
Setting this flag to `true` gives a hint to renderer implementation to
reduce the latency between the input and visual changes in exchange for
possible screen tearing.

---------

Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elijah-semyonov elijah-semyonov

Labels
desktop p:high High priority performance rendering Low level rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add constructor with RenderSettings to ComposePanel JetBrains/compose-multiplatform-core
3 participants
@elijah-semyonov @igordmn @MohamedRejeb