Add MS SQL Server Dialect #53
Comments
|
Sorry, but we don't have enough experience with MSSQL and MSSQL Compact for unit test, so if have - please PR SQLServerDialect. You can find examples in H2.kt, Mysql.kt |
… have ORDER BY clause already.
…ys after batch insert.
…tores milliseconds.
|
I added support for MSSQL in https://github.com/YakovSirotkin/Exposed/tree/sqlserver-dialect, but I want to wait with pull request until clarification with #155 Testing with Docker is not trivial and maybe it will be possible to re-use approach for Oracle tests to SQL Server. |
|
I created pull request #164 with SQL Server support, but I am not sure about Docker tests. Maybe it makes sense to create one tests with 2 Docker instance with Oracle and SQL Server. |
|
Ok, I will check PR next week and will try to setup single TC configuration to run both DBMS. |
|
Would be great to get MS SQL support in Exposed. We're about to start integrating our services with our Azure backend. Happy to help with testing/validation if that's of benefit. |
|
@Tapac Do you have a plan how to add SQL Server support? Maybe we can create branch in main repo from #164 (comment)? At least it will be easier to keep branch up-to-date. |
* #53 namedEmptyTableWithoutQuotesSQL test works only with H2 * #53 Add alreadyOrdered parameter to limit function for SQLServer support. * #53 SQLServer support * #53 Provide additional parameter to limit() that shows if we have ORDER BY clause already. * #53 Workaround for SQLServer that do not return generated keys after batch insert. * #53 Workaround for SQLServer that requires special blob handling. * #53 Disable time-related tests for SQLServer where it has no chance. * #53 Register SQLServer dialect. * #53 Workaround for SQLServer that looses precision when it stores milliseconds. * #53 Add SQLServer driver dependency. * #53 Add SQLServer support. * #53 Update for limitations section. * #53 Use currentDialect. * #53 Driver dependencies are fixed already. * #53 Add property for dialect for Docker tests. * #53 Update instructions how to start Docker. * #53 Use system properties for SQLSERVER configuration. * #53 Support Docker tests for Oracle and SQLServer. * #53 Switch to SQL Server JDBC driver for Java 7. * #53 Remove Oracle-specific Docker properties.
|
@YakovSirotkin, finally I'm ready to merge your branch with SQLDialect into master and create a release. Also, I found out that DATETIME2 type doesn't have that problem with losing millis. |
|
@Tapac thanks a lot for all your work! I think that I don't have account at kotlinlang.slack.com because I don't have email at jetbrains.com:) |
|
@YakovSirotkin , I'm not sure that it's required to, but sent you invitation to @telamon.ru anyway . |
|
@Tapac, thanks a lot, I just registered. |
I'm trying to perform a
limitquery against a Microsoft SQL Server database, but I'm getting a "No dialect registered for sqlserver" error. Exposed could use a SQLServerDialect class.The text was updated successfully, but these errors were encountered: