Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reloading on jbr_dcevm-17_0_1-osx-aarch64-b164.8 #102

Closed
mworzala opened this issue Dec 10, 2021 · 10 comments
Closed

Crash when reloading on jbr_dcevm-17_0_1-osx-aarch64-b164.8 #102

mworzala opened this issue Dec 10, 2021 · 10 comments

Comments

@mworzala
Copy link

mworzala commented Dec 10, 2021

When reloading using dcevm/hotswap agent on jbr_dcevm-17_0_1-osx-aarch64-b164.8, the reload happens and then the JVM crashes immediately. I have attached the crash report, let me know if any other information is helpful.

hs_err_pid17685.log

@mworzala
Copy link
Author

Hmm some more context, on a simpler project it does not crash but also does not apply the reloaded changes and prints

HOTSWAP AGENT: 22:34:47.539 ERROR (org.hotswap.agent.plugin.jdk.JdkPlugin) - classReload() exception No such field java.beans.Introspector.declaredMethodCache on null.

in the terminal. This error popped up on the original project as well.

@skybber
Copy link
Collaborator

skybber commented Dec 10, 2021

You can ignore the HA error message. HA is not fully ported to java17 now. The crash seems more serious, is it reproducible?

@mworzala
Copy link
Author

It’s consistent in one project, doesn’t happen in another. Although in the latter case nothing is reloaded as far as I can tell.

@skybber
Copy link
Collaborator

skybber commented Dec 11, 2021

Is it possible to describe steps how to reproduce it on your https://github.com/Minestom/Minestom project?

@mworzala
Copy link
Author

  1. git clone https://github.com/Minestom/Minestom
  2. git checkout 529_extension_improvement
  3. (the rest in IntelliJ for convenience)
  4. Project/gradle jdk to JBR
  5. Debug src/test/java/demo/Main with -XX:HotswapAgent=fatjar
  6. Make an edit at src/main/java/net/minestom/server/instance/InstanceContainer#L465 (for example a system print)
  7. Recompile/reload InstanceContainer.java
  8. Crash

This is consistent on my machine. The crash does not seem consistent at other locations. That one always crashes though.

@skybber
Copy link
Collaborator

skybber commented Dec 11, 2021

@mworzala thanks for great report. I've fix now for it, it should be included in next release.

@skybber
Copy link
Collaborator

skybber commented Dec 12, 2021

@mworzala before patch will be available, you can use -XX:-UseEmptySlotsInSupers as a workaround for your issue.

@mworzala
Copy link
Author

Looks like that's working, thanks for the quick responses and patch!

I will close the issue for now, but if you could make a comment when the next release happens that would be great.

@skybber skybber reopened this Dec 12, 2021
@avu
Copy link
Collaborator

avu commented Feb 10, 2022

@skybber why did you reopened this issue? Is it not fixed yet?

@skybber
Copy link
Collaborator

skybber commented Feb 10, 2022

already fixed in java17.

@skybber skybber closed this as completed Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants