Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about #[Internal]? #2

Closed
dsentker opened this issue Nov 24, 2020 · 1 comment
Closed

How about #[Internal]? #2

dsentker opened this issue Nov 24, 2020 · 1 comment

Comments

@dsentker
Copy link

Similar to the @internal Annotation it would be useful to mark classes and methods for internal use (limited scope) only. The annotation is currently only supported for classes, not methods.

@wbars
Copy link
Member

wbars commented Nov 24, 2020

Hello. While your suggestion surely make sense, I think this is not exactly use case for these particular attributes ATM. @internal PhpDoc already widely used and even somewhat documented in https://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.internal.pkg.html.
Also I don't see what additional opportunities migrating this to attributes will open to users (in @deprecated for example we now able to provide more metadata using attributes).

I will decline this proposal for now, but these may be reconsidered in future. Thank you for the suggestion.

@wbars wbars closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants