-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running skija with Java 8 #57
Comments
Good question—have you tried it? What didn’t work? |
This is what we depend on https://docs.oracle.com/javase/9/docs/api/java/lang/ref/Cleaner.html, avaliable since 9. So I guess the minimal version is 9 |
Yeah i tried. I just modified the pom.xml to change the compiler version from 11 to 8, and i had an error about what you said. Thank you for the answer. Now i think there is no chance that this could be work with java 8. |
I tried to replace java.lang.ref.Cleaner with sun.misc.Cleaner and it worked.
}` |
Great! |
Yeah it's really good ! I'm gonna try that 👍 Thanks again ! |
I don’t know a way to make two different classes for two different JVM versions. Out of curiosity, what are the reasons that make you stay on Java 8? |
Just because of legacy :) I will take time to upgrade my app to java 11 but for huge application it's not so easy to do it unfortunately. That is why, it would have been easier if Skija could work directly with Java 8 in my case. But it's now good to know that it can works with Java 8. |
@tonsky Coincidentally, Java 9 introduced exactly that feature! 😄 There's a great guide for Maven use here: https://www.baeldung.com/maven-multi-release-jars |
Great! Do you want to work on that? I’d be happy to review a PR |
Any status on this? |
@Jojal How do you modified the scripts to support compile? When I just replace java.lang.ref.Cleaner with sun.misc.Cleaner and run /script/build.py, it says there's no options like "--release", "--class-path" and "--module-path". After search I found these options only support in Java 9, cause I'm new in Java that do not have any idea to modify it. So if any help about how to compile it with Java 8. Thanks in advance! |
@luojinrong I am curious what keeps you on Java 8? If you are new, why not start with the latest? Java 8 was released in 2014 |
Cause only I'm new, uhh...but my company use java 8 on its servers. We prefer using skija with java 8 than upgrading java version on servers. |
How do you plan to use Skija on the servers? Just curious |
I'd like to use Skija with the LWJGL backend on older versions of Minecraft, which still run on Java 8 and cannot be updated due to an outdated Netty dependency. Is there any workaround for this so I can use Skija with Java 8? |
@Lucaskyy just at the beginning of this thread, there’s a workaround |
@Jojal @yuhailong626 @Magneticflux @Sm0keySa1m0n @luojinrong @Sculas HumbleUI/Skija has provided Java 8 support since 0.109.0. |
Hi everyone,
I was wondering if there is any possibility to make skija wordking with java 8 please ? Maybe a trick or something ? I need to swith to java 11, but due to some legacy code, i still need to wait a bit and i would love to try make skija working with my java 8 app.
Thank's a lot.
The text was updated successfully, but these errors were encountered: