Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractSVGPlugin outputs [object Object] for all symbol IDs #66

Closed
rosscourt opened this issue Nov 2, 2016 · 5 comments
Closed

ExtractSVGPlugin outputs [object Object] for all symbol IDs #66

rosscourt opened this issue Nov 2, 2016 · 5 comments
Labels
Milestone

Comments

@rosscourt
Copy link

As @farwayer posted here:
#54 (comment)

And the demo:
#54 (comment)

I wanted to open a dedicated issue for this so that they is somewhere to track it that isn't just the end of a already closed issue (#54).

@kisenka, is this what you were trying to work out in this repo? https://github.com/kisenka/multiple-extract-text-webpack-plugins

@kisenka
Copy link
Contributor

kisenka commented Nov 2, 2016

@rosscourt > is this what you were trying to work out in this repo?
yes.

If you want to extract symbols in separate file via extract-text-webpack-plugin and want import statement to return a symbol id you anyway should patch extract-text-webpack-plugin loader :( Because by default it replace module exports with // removed by extract-text-webpack-plugin

@kirill-kruchkov
Copy link

Hello! I tried to use Extract SVG too. Here's a workaround I came up with: you can run two separate/parallel builds, first one with loader to make your client bundle and insert correct ids into your 's, and second with extract to create bundle svg file.
Seems OK for me for now, 'cause I'm experimenting with pre-rendering html files for certain routes of my app using two separate builds.

@kisenka kisenka mentioned this issue Apr 23, 2017
@kisenka
Copy link
Contributor

kisenka commented Apr 23, 2017

@kirill-kruchkov

That's weird! :) svg-sprite-loader@2.0 with proper extracting mode is on the way, please read about it here #91 and take part in discussion/voting.

@kirill-kruchkov
Copy link

@kisenka well, it's ok for experimentation. Never goes to production :)

@kisenka
Copy link
Contributor

kisenka commented Apr 28, 2017

Closing this because proper sprite extracting was implemented in new 2.0 version. Please update.

@kisenka kisenka closed this as completed Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants