boxcli: don't print help w/ shell non-zero exit code #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't print an error message or the usage help when `devbox shell` exits with a non-zero code. We still want to propagate the shell's exit code in order to support scripts. Before: $ devbox shell Installing nix packages. This may take a while... Starting a devbox shell... $ exit 1 Usage: devbox shell [<dir>] [flags] Flags: -h, --help help for shell After: $ devbox shell Installing nix packages. This may take a while... Starting a devbox shell... $ exit 1 $ echo $? 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't print an error message or the usage help when
devbox shellexits with a non-zero code. We still want to propagate the shell's exit code in order to support scripts.Before:
After:
How was it tested?
devbox shelland exiting 1 to check there's no error output.devbox shellto check I still see an error.