Do not generate dockerfile on shell command #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loreto
reviewed
Sep 2, 2022
generate.go
Outdated
| @@ -18,9 +18,12 @@ import ( | |||
| //go:embed tmpl/* tmpl/.* | |||
| var tmplFS embed.FS | |||
|
|
|||
| func generate(rootPath string, plan *planner.Plan) error { | |||
| func generate(rootPath string, plan *planner.Plan, includeBuildFiles bool) error { | |||
There was a problem hiding this comment.
I don't love the bool.
How about this:
you change generate to take a string array.
you add generateNix (which calls generate with .gitignore, shell.nix, default.nix)
you add 'generateDockerfile(which callsgeneratewith.gitignore, Dockerfile`)
gcurtis
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not generate dockerfile on shell command, as someone who is using the shell command may not need to use language detector, or need to fill in
install,buildandstartcommand if the language planner is absent.How was it tested?
devbox shell
devbox generate
devbox build