Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CICD]: add spell chcker to GitHub action #658

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[CICD]: add spell chcker to GitHub action #658

merged 1 commit into from
Mar 2, 2023

Conversation

hezhizhen
Copy link
Contributor

Summary

Add https://github.com/crate-ci/typos to GitHub action and fix existing typos.

How was it tested?

@hezhizhen
[CICD]: add spell chcker to GitHub action
cb2aefe 
Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com>
ipince
ipince approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ipince ipince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hezhizhen
Copy link
Contributor Author

Not ready to merge it? @ipince

@savil savil merged commit 706ac42 into jetify-com:main Mar 2, 2023
@savil
Copy link
Collaborator

savil commented Mar 2, 2023

@hezhizhen thanks! I think @ipince just forgot that you don't have merging privileges.

@mikeland73
Copy link
Contributor

We should probably change this to not run on main branch and if possible also ignore some file types (e.g. .svg)

@savil
Copy link
Collaborator

savil commented Mar 2, 2023

@mikeland86 i'll send an update

@savil savil mentioned this pull request Mar 2, 2023
Merged
savil added a commit that referenced this pull request Mar 2, 2023
@savil
[spell check cicd] do not run on main branch, and ignore .svg files (#…
c249fa1 
…714)

## Summary

follow up to #658


## How was it tested?

will observe github actions run
@hezhizhen hezhizhen deleted the typos-lint branch August 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipince ipince ipince approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hezhizhen @savil @mikeland73 @ipince