[examples] enable stacks-django and rust examples to pass #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
1 task
savil
force-pushed
the
savil/exit-on-failure-scripts
branch
from
33755df
to
fad67f5
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
6cf163c
to
6e234a1
Compare
savil
force-pushed
the
savil/exit-on-failure-scripts
branch
from
fad67f5
to
7ef9aac
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
3 times, most recently
from
6cba2d1
to
31183e7
Compare
savil
changed the base branch from
savil/exit-on-failure-scripts
to
savil/lepp-stack-fixes
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
31183e7
to
2847358
Compare
savil
changed the title
savil
force-pushed
the
savil/testscripts-env-functions
branch
2 times, most recently
from
7038c73
to
ad06e55
Compare
Lagoja
approved these changes
Apr 10, 2023
| @@ -10,14 +10,17 @@ | |||
| "mkdir -p $rustupHomeDir", | |||
| "export RUSTUP_HOME=$rustupHomeDir", | |||
| "export LIBRARY_PATH=$LIBRARY_PATH:\"$projectDir/nix/profile/default/lib\"", | |||
| "source conf/set-env.sh", | |||
There was a problem hiding this comment.
Does this work? We had to change the mariadb example to use source in order for the env variables to stick in the shell
There was a problem hiding this comment.
Looking more closely, I don't understand why we need the lines prior to . conf/set-env.sh.
With the above lines, the mkdir -p $rustupHomeDir gives an error when I do devbox run run_test.
When I try devbox run run_test without the above lines, everything works as expected. Also, did devbox shell and echo $RUSTUP_HOME to confirm it prints the path/to/projectDir/conf as expected.
I've removed the lines prior to . conf/set-env.sh
savil
force-pushed
the
savil/lepp-stack-fixes
branch
from
ccdce85
to
4005b19
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
ad06e55
to
73ba576
Compare
savil
force-pushed
the
savil/lepp-stack-fixes
branch
from
4005b19
to
d926d71
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
73ba576
to
327692e
Compare
savil
force-pushed
the
savil/lepp-stack-fixes
branch
from
d926d71
to
b3f465b
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
327692e
to
3c1b417
Compare
savil
force-pushed
the
savil/lepp-stack-fixes
branch
from
b3f465b
to
783be5c
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
3c1b417
to
069ec79
Compare
…t path is too long" error
…sureVirtenvXYZ functions, use 5 length hash, and minor other changes
…kPath (3) override XDG_STATE_HOME for examples testscripts
savil
force-pushed
the
savil/lepp-stack-fixes
branch
from
783be5c
to
9497fff
Compare
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
1f39049
to
3397c47
Compare
savil
commented
Apr 11, 2023
| "export RUSTUP_HOME=$rustupHomeDir", | ||
| "export LIBRARY_PATH=$LIBRARY_PATH:\"$projectDir/nix/profile/default/lib\"", | ||
| "source conf/set-env.sh", | ||
| ". conf/set-env.sh", |
There was a problem hiding this comment.
NOTE: #890 improves the rust-example further. Will land this PR as-is, and merge with that PR's changes.
savil
force-pushed
the
savil/testscripts-env-functions
branch
from
3397c47
to
3d43a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues:
django:
8089which is different than the default which wasn't working in CICD for some reason.devbox services startanddevbox services stoprust: changed non-posix
sourceto posix-compliant.How was it tested?
added
set -eto both and see buildkite run be green.