[tests] Tests should not modify config #883
Conversation
| os.Getenv("DEVBOX_DONT_UPGRADE_CONFIG"), | ||
| ); dontUpgrade { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I'm surprised this works. Does it actually use our desired defaultNixPkgsCommit? or just nixpkgs and "seem to work" because tests happen to pass?
I would have thought you want to just gate the writeConfig below, but continue to write:
cfg.Nixpkgs.Commit = plansdk.DefaultNixpkgsCommit
so that the code works as we want by using the DefaultNixpkgsCommit
There was a problem hiding this comment.
The code correctly defaults to DefaultNixpkgsCommit if none is set.
Gating writeConfig felt wrong because what is specifically causing the writes is the upgrade. (This may change if we decide to add packages dynamically, but in that case gating writeConfig will break that).
I actually was thinking of adding something to the test that confirms that devbox.json has not changed (since it should not)
Summary
This allows us to run tests without modifying example devbox.json configs.
How was it tested?
go test ./...