nixstore: add package for querying and resolving Nix store paths #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Nice!
I'm not sure I'll be much help reviewing the actual implementation (without spending additional time to learn a lot of it myself), but the idea and structure look good.
I think if there are a few low hanging possible unit tests or integration tests that would be pretty nice (e.g. install some stuff with devbox and then use this to retrieve a package and dependencies)
|
|
||
| // TopologicalSort resolves the dependency tree for a package and returns it as | ||
| // a slice of packages in topological order. | ||
| func TopologicalSort(pkg *Package) []*Package { |
There was a problem hiding this comment.
put sort functions into own file.
gcurtis
force-pushed
the
gcurtis/nixstore
branch
from
faf8987
to
02d4f6c
Compare
Given the store name of a Nix package, a `nixstore.Root` can return a slice of transitive package dependencies in topological order without invoking a separate Nix process. This builds on top of the code from c009546. Once we have a search index of attribute paths to store paths, this will allow Devbox to bypass nixpkgs evaluation by resolving and installing packages directly. Follow-up improvements: - Cache resolved package dependencies so that they don't need to be recomputed every time. - Support for resolving dependencies using .narinfo files.
gcurtis
force-pushed
the
gcurtis/nixstore
branch
from
02d4f6c
to
d33219f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the store name of a Nix package, a
nixstore.Rootcan return a slice of transitive package dependencies in topological order without invoking a separate Nix process. This builds on top of the code from c009546.Once we have a search index of attribute paths to store paths, this will allow Devbox to bypass nixpkgs evaluation by resolving and installing packages directly.
Follow-up improvements: