[shell] source the hooks file in shellrc #890
Conversation
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
🤔 I need to:
|
| @@ -1 +1 @@ | |||
| echo "Hello from a devbox shell hook!" | |||
| /path/to/hooksfile/hooks.sh | |||
| @@ -1 +1 @@ | |||
| echo "Hello from a devbox shell hook!" | |||
| /path/to/hooksfile/hooks.sh | |||
There was a problem hiding this comment.
why is this file this? i dont get it
There was a problem hiding this comment.
it contains a (fake) path-to-the-hooks file.
I could: rename the file from hooks.sh to path-to-hooks-file.txt.
Not sure how else to capture the two scenarios of this hooks file being missing or not. 🤔 is it always present?
There was a problem hiding this comment.
ah, okay, we always write this. Confirmed by doing devbox init for an empty project, DEVBOX_DEBUG=1 devbox shell and inspecting the generated shellrc file: We source a hooks file which exists but is empty.
I will:
(a) delete this shellrc/nohook test case
(b) expose a function for the hooksFilePath and refer to that in the testcase logic.
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| env, err := d.nixEnv(ctx) |
There was a problem hiding this comment.
somewhere around here, we should ensure the script files are written. see the run impl
you can test if they're being written by deleting .devbox/gen/scripts and then running devbox shell
There was a problem hiding this comment.
on line 164: d.ensurePackagesAreInstalled
-> d.generateShellFiles
-> d.writeScriptsToFiles
savil
force-pushed
the
savil/source-hooks-in-shellrc
branch
from
9352874
to
fa9dbb7
Compare
|
@ipince please see last commit. I made a few changes. |
| written[d.scriptPath(hooksFilename)] = struct{}{} | ||
|
|
||
| // Write scripts to files. | ||
| for name, body := range d.cfg.Shell.Scripts { | ||
| err = d.writeScriptFile(name, d.scriptBody(body.String())) | ||
| if err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
| written[d.scriptFilename(name)] = struct{}{} | ||
| written[d.scriptPath(name)] = struct{}{} |
There was a problem hiding this comment.
@ipince these two changes have a small logic change: the map's key was filename and is not filepath. I think this is safe.
Changes: - refactor: use d.scriptPath everywhere, and delete d.scriptFilename - remove nohook shell test case - remove `hook` files from shell test cases
savil
force-pushed
the
savil/source-hooks-in-shellrc
branch
from
fa9dbb7
to
6918c39
Compare
This reverts commit ea6fb6d.
Summary
Also, fix up the rust example
How was it tested?
ran
DEVBOX_DEBUG=1 devbox shelland inspected the output to find the temp-dir in which the shellrc was written toRust example
and