bring back shell.nix, but keep development.nix deleted #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do:
revert [cleanup] delete unused shell.nix and development.nix templates #891
delete development.nix
Turns out we do use the shell.nix in the envrc.tmpl. I should've done a
git grep shell.nix
.No tests failed. We need better direnv test coverage.
How was it tested?
have not tested
will rely on buildkite tests