[lockfile] Add hidden lockfile for caching #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Apr 12, 2023
|
@gcurtis I'm going to rename this to possible |
Both names work for me since this is a hidden file. Why doesn't the manifest hash work? I think it should work for the local machine, so as long as it isn't committed it should be okay. |
Yeah for non-committed files manifest is OK. I was just thinking we would eventually move this out of hidden. |
mikeland73
added a commit
that referenced
this pull request
Apr 12, 2023
## Summary Stacked on #897 This significantly improves `run` and `shell` performance (`run` goes from 500ms -> 150ms without telemetry) Almost all remaining time for run and shell involves the `exec.Command` so this is close to as fast as it will get. ## How was it tested? ```bash devbox add hello time devbox run which hello ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a hidden lock file for caching purposes.
Motivation:
This speeds up run/shell by only running
ensurePackagesAreInstalledif config or nix profile manifest has changed.Why hidden?
I'm not ready for this to be an official checked-in lock file. So for now it lives in
.devboxand does not get committed to repo.How was it tested?
In flakes example ran:
devbox run echo 5and got a speed up of around 66%.
Also tested