Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cicd] bump timeouts for cli-tests #905

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

savil
Copy link
Collaborator

@savil savil commented Apr 13, 2023

Summary

The test-step cli-test timeout needs to be bigger than the go test --timeout value
since we run other steps prior to it.

Also bumped the go test timeout, just to be safe.

Obviously, this is not a long term solution. We need a way of caching the nix packages,
but in the meantime prefer to have the Github Actions be Green.

How was it tested?

buildkite run should be green

Copy link
Collaborator Author

savil commented Apr 13, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil requested review from loreto and mikeland73 April 13, 2023 00:39
@savil savil merged commit 5ae8c20 into main Apr 13, 2023
9 checks passed
@savil savil deleted the savil/bump-cli-test-timeouts branch April 13, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants