Do not deploy runtime chart if runtime is not needed DEV-1225

[LucilleH]

Summary

If runtime is not needed, do not deploy runtime helm chart

How was it tested?

launchpad up

Is this change backwards-compatible?

Yes

[mikeland73]

Take a look at https://github.com/jetpack-io/launchpad/blob/main/launchpad/deploy.go#L312 which is already skipping the runtime. It looks like we're taking to slightly different approaches, maybe there's a way to unify?

[LucilleH]

Take a look at https://github.com/jetpack-io/launchpad/blob/main/launchpad/deploy.go#L312 which is already skipping the runtime. It looks like we're taking to slightly different approaches, maybe there's a way to unify?

Oh good point. Updated.

The previous way have a downside of downloading and generating the information needed for the runtime chart which requires user information, even when runtime is not needed. The current way avoids this step if runtime is not needed.

I think we still need the runSDKRegistration bool for the helm chart values so I'll keep that, and that is also derived from the same detect.Sdk function. So I think now it is unified. Thoughts? @mikeland86

[ipince]

move to line 112 (closer to its assignment)?