Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands to set cluster properly before identifying the user #15

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix commands to set cluster properly before identifying the user #15

merged 1 commit into from
Nov 10, 2022

Conversation

LucilleH
Copy link
Collaborator

@LucilleH LucilleH commented Nov 9, 2022 •
edited

Summary

Fix commands to set cluster properly before identifying the user. Now that we rely on setClusterName before Identify call.

Specifically, authProvider.Identify needs to happen after loadOrInitConfigFromFileSystem

How was it tested?

launchpad up
launchpad env
...
and all the commands affected

Is this change backwards-compatible?

yes

ipince
ipince approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@ipince ipince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad times

@LucilleH LucilleH merged commit 827171a into main Nov 10, 2022
@LucilleH LucilleH deleted the lucille--fix-env-cmd branch November 10, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipince ipince ipince approved these changes

@mikeland73 mikeland73 Awaiting requested review from mikeland73

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucilleH @ipince