Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture public aws ecr image repository uri DEV-1247 #16

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Capture public aws ecr image repository uri DEV-1247 #16

merged 1 commit into from
Nov 11, 2022

Conversation

LucilleH
Copy link
Collaborator

Summary

Aws ECR regex should match private and public repository uri. Public ECR URI prefixes with public.ecr.aws/

How was it tested?

launchpad up

Is this change backwards-compatible?

yes

mikeland73
mikeland73 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@mikeland73 mikeland73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, I don't like this regex at all but not your fault.

I wonder if doing just a few string contains checks might be easier to read

@LucilleH LucilleH merged commit 903fd4f into main Nov 11, 2022
@LucilleH LucilleH deleted the lucille--public-aws-ecr branch November 11, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeland73 mikeland73 mikeland73 approved these changes

@ipince ipince Awaiting requested review from ipince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucilleH @mikeland73