Remove hardcoded smarthop related fields DEV-1227 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm we'd have to check if it'll affect Smarthop |
|
I mean, this will definitely break Smarthop. It won't break it when merged, but it'll break it the next time they deploy... |
mikeland73
approved these changes
Nov 14, 2022
|
I think this is fine. @Lagoja can send them a slack message to let them know and we can tell them how to set up a custom URL? |
|
Can you share what I need to send them over Slack? |
|
Need to remove this from open-source. Merging. |
|
Note: this is not backwards-compatible, because some public api in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove hardcoded smarthop related fields. Is it safe to remove?
How was it tested?
launchpad up
Is this change backwards-compatible?
yes-ish