Allow to configure the name of the keystore file

[hguerrero]

Is your feature request related to a problem? Please describe.
Some applications require a specific name for the JKS file, so hardcoding it to keystore.jks requires to edit the secret to fix the name.

Describe the solution you'd like
Under the JKS object add a field to add the desired name for the keystore

Describe alternatives you've considered
none

Additional context

Environment details (if applicable):

• cert-manager version (e.g. v0.4.0):0.15.0
• openshift: 4.3

/kind feature

[meyskens]

/priority important-soon

[munnerz]

I don't think this is something we should/need to expose in our CRD schema - it is already possible to 'remap' the name of items in a Secret resource when mounting them into a pod: https://kubernetes.io/docs/concepts/configuration/secret/#projection-of-secret-keys-to-specific-paths

This is what we've typically advised for users who have had similar requests for the tls.crt and tls.key entries too.

/priority awaiting-more-evidence

[hguerrero]

It can be remap to other name if you have control of the Deployment CR, but it is not the case when using for example, Kubernetes Operators where the operator is in charge of creating the required CRs and updating them in case there are changes. So updating the Deployment won't work because the Operator might overwrite the changes.

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[hguerrero]

Back to this again, we still have the use case where we need to provide a specific name for the file. Having the cert-manager flexible enough to name the files makes it more usable.

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[jetstack-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

[jetstack-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

[jetstack-bot]

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PaskeS]

Still very much a useful feature. Just to provide a clear example of when we cant just change the name ourself
https://github.com/bitnami/charts/blob/main/bitnami/schema-registry/templates/statefulset.yaml#L107-L113
https://github.com/bitnami/charts/blob/main/bitnami/schema-registry/values.yaml#L142-L147

This would solve the problem perfectly. I understand that there is also an argument to allow the keystore names to be set in the templates for the above. A feature like this would just allow us to solve at the source vs udating many others templates

My solution for this current case is to just not use cert manager and do it myself unfortunately