Error when setting override to docker.io/busybox

[jwitko]

When setting annotation:
override-url.version-checker.io/fsgroup-volume: docker.io/busybox
I get the following error:

time="2023-10-17T16:42:30Z" level=error msg="error syncing 'opensearch-us5-data-0-25/opensearch': failed to sync pod opensearch-us5-data-0-25/opensearch: failed to check container image \"fsgroup-volume\": failed to get tags from remote registry for \"docker.io/busybox\": failed to parse image timestamp: parsing time \"\" as \"2006-01-02T15:04:05.999999999Z07:00\": cannot parse \"\" as \"2006\",failed to check container image \"sysctl\": failed to get tags from remote registry for \"docker.io/busybox\": failed to parse image timestamp: parsing time \"\" as \"2006-01-02T15:04:05.999999999Z07:00\": cannot parse \"\" as \"2006\", requeuing" module=controller

[davidcollom]

So I've done some digging and extra debug output locally and come to the conclusion that this is a data retention/consistency issue within the Registry's datastore.

This was confirmed with the following:

$ curl -s 'https://registry.hub.docker.com/v2/repositories/library/busybox/tags?page_size=100&page=2' | jq -r '.results[] | select(.last_updated==null) |{name: .name, used: .last_updated}'
{
  "name": "1.23",
  "used": null
}
{
  "name": "1.23.2",
  "used": null
}
{
  "name": "buildroot-2013.08.1",
  "used": null
}

These images (based on the latest busybox image being 1.36.1 at time of posting/investigating appear to be very old images.

The issue/bug I see in version-checker is that this is a hard failure and ends up not being able to actually monitor the version of said image.

I've confirmed that, version-checker was able to validate and get the latest image for busybox with the changes proposed:

DEBU[0614] image is not latest xxxxxxxx/yyyyy: main -> 1.36.1  container=portal module=controller name=davidcollom-0 namespace=davidtest1-davidcollom