Define credentials as a environment variable

[nonamef]

Currently if you want to add any username/password, it's done as a string. As the helm chart code is stored in a repository, anyone with access can see the credentials without issue.
e.g

# Docker Hub Credentials Configuration
docker:
  username:  admin-user
  password: password123

An enhancement would be to define the credentials as an environment variable so that secrets could be used to mask the credentials.
e.g

env:
  - name: DOCKER_USERNAME
    valueFrom:
      secretKeyRef:
        name: docker-credentials
        key: username
  - name: DOCKER_PASSWORD
    valueFrom:
      secretKeyRef:
        name: docker-credentials
        key: password

[nonamef]

Looks like I missed the defined vars in the deployment. Would be good if it was in the readme.

version-checker/deploy/charts/version-checker/templates/deployment.yaml

Line 134 in 74cde3c

- name: VERSION_CHECKER_DOCKER_USERNAME

        {{- if .Values.docker.username }}
        - name: VERSION_CHECKER_DOCKER_USERNAME
          valueFrom:
            secretKeyRef:
              name: {{ $chartname }}
              key: docker.username
        {{- end }}
        {{- if .Values.docker.password }}
        - name: VERSION_CHECKER_DOCKER_PASSWORD
          valueFrom:
            secretKeyRef:
              name: {{ $chartname }}
              key: docker.password
        {{- end }}