Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jettison 1.3.x array handling breaks XStream #12

Closed
sberyozkin opened this issue May 14, 2015 · 1 comment
Closed

Jettison 1.3.x array handling breaks XStream #12

sberyozkin opened this issue May 14, 2015 · 1 comment

Comments

@sberyozkin
Copy link
Contributor

With the latest version it is no longer possible to enfore array handling for an element. Actually the serializeAsArray flag triggers non-symmetric behavior of Jettison between its reader and writer. See following unit tests, that represent XStream's internal call sequence and which succeed with Jettison 1.2.

{code:java}
public void testJettisonArraysAreBroken() throws XMLStreamException {
final MappedXMLOutputFactory mof;
final MappedXMLInputFactory mif;
final Configuration config = new Configuration();
mof = new MappedXMLOutputFactory(config);
mif = new MappedXMLInputFactory(config);
ByteArrayOutputStream out = new ByteArrayOutputStream();
XMLStreamWriter writer = mof.createXMLStreamWriter(out);
((AbstractXMLStreamWriter)writer).serializeAsArray("list");
writer.writeStartDocument();
writer.writeStartElement("list");
writer.writeStartElement("string");
writer.writeCharacters("a");
writer.writeEndElement();
writer.writeStartElement("string");
writer.writeCharacters("b");
writer.writeEndElement();
writer.writeEndElement();
writer.writeEndDocument();
writer.close();
assertEquals("{'list':[{'string':['a','b']}]}".replace(''', '"'), out.toString());
ByteArrayInputStream in = new ByteArrayInputStream(out.toByteArray());
XMLStreamReader reader = mif.createXMLStreamReader(in);
assertEquals(XMLStreamConstants.START_ELEMENT, reader.next());
assertEquals("list", reader.getLocalName());
assertEquals(XMLStreamConstants.START_ELEMENT, reader.next());
assertEquals("string", reader.getLocalName());
assertEquals(XMLStreamConstants.CHARACTERS, reader.next());
assertEquals("a", reader.getElementText());
assertEquals(XMLStreamConstants.END_ELEMENT, reader.next());
assertEquals(XMLStreamConstants.START_ELEMENT, reader.next());
assertEquals("string", reader.getLocalName());
assertEquals(XMLStreamConstants.CHARACTERS, reader.next());
assertEquals("b", reader.getElementText());
assertEquals(XMLStreamConstants.END_ELEMENT, reader.next());
assertEquals(XMLStreamConstants.END_ELEMENT, reader.next());
}

public void testJettisonSingleElementArraysAreBroken() throws XMLStreamException {
    final MappedXMLOutputFactory mof;
    final MappedXMLInputFactory mif;
    final Configuration config = new Configuration();
    mof = new MappedXMLOutputFactory(config);
    mif = new MappedXMLInputFactory(config);
    ByteArrayOutputStream out = new ByteArrayOutputStream();
    XMLStreamWriter writer = mof.createXMLStreamWriter(out);
    ((AbstractXMLStreamWriter)writer).serializeAsArray("list");
    writer.writeStartDocument();
    writer.writeStartElement("list");
    writer.writeStartElement("string");
    writer.writeCharacters("a");
    writer.writeEndElement();
    writer.writeEndElement();
    writer.writeEndDocument();
    writer.close();
    assertEquals("{'list':[{'string':'a'}]}".replace('\'', '"'), out.toString());
    ByteArrayInputStream in = new ByteArrayInputStream(out.toByteArray());
    XMLStreamReader reader = mif.createXMLStreamReader(in);
    assertEquals(XMLStreamConstants.START_ELEMENT, reader.next());
    assertEquals("list", reader.getLocalName());
    assertEquals(XMLStreamConstants.START_ELEMENT, reader.next());
    assertEquals("string", reader.getLocalName());
    assertEquals(XMLStreamConstants.CHARACTERS, reader.next());
    assertEquals("a", reader.getElementText());
    assertEquals(XMLStreamConstants.END_ELEMENT, reader.next());
    assertEquals(XMLStreamConstants.END_ELEMENT, reader.next());
}

{code}

@dkulp
Copy link
Contributor

dkulp commented Mar 18, 2020

Resolved via a new config option to restore old behavior.

@dkulp dkulp closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants