Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge custom_parse into custom_func and retire custom_parse? #134

Closed
jf-tech opened this issue Dec 14, 2020 · 0 comments · Fixed by #135
Closed

Merge custom_parse into custom_func and retire custom_parse? #134

jf-tech opened this issue Dec 14, 2020 · 0 comments · Fixed by #135
Assignees
@jf-tech

Comments

@jf-tech
Copy link
Owner

jf-tech commented Dec 14, 2020 •
edited

Previously we created custom_parse because of limitation of return type of a custom_func must be string. Since we revamped custom_func type system because of javascript introduction, seems like there is no reason for custom_parse to exist anymore. custom_parse is simply just another custom_func with transformctx and idr.Node two arguments and an arbitrary interface{} return type.

Should we just deprecate and retire custom_parse?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jf-tech jf-tech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate custom_parse in favor of custom_func jf-tech/omniparser
1 participant
@jf-tech