Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linenumbers not working with [data] attribute #135

Closed
StefanKern opened this issue Feb 25, 2019 · 6 comments
Closed

linenumbers not working with [data] attribute #135

StefanKern opened this issue Feb 25, 2019 · 6 comments
Labels
bug Unexpected behavior

Comments

@StefanKern
Copy link

When using a [data] attribute, the lineNumbers are not working.

Minimal example:

  <markdown [data]="json| language : 'json'" lineNumbers ngPreserveWhitespaces>
  </markdown>

(json = '{"hello": "world"}')

@jfcere
Copy link
Owner

jfcere commented Feb 25, 2019

Hi @StefanKern, thanks for reporting the issue, I'm going to take a look at it tonight.

@StefanKern
Copy link
Author

@jfcere thanks. The problem can be reproduced in the demo project. I tried a stackblitz but gave up.. if you need anything more please say so :)

@jfcere jfcere added the bug Unexpected behavior label Feb 26, 2019
@jfcere
Copy link
Owner

jfcere commented Feb 26, 2019

I've released a beta version so you can confirm problem is fixed on your end.
Please update ngx-markdown to 7.1.4-beta.0 and keep me posted.

@StefanKern
Copy link
Author

I can confirm, that it works:
image

@jfcere
Copy link
Owner

jfcere commented Feb 26, 2019

Great, thanks for the feedback. I'm going to release it as 7.1.4 tonight.

@jfcere
Copy link
Owner

jfcere commented Mar 1, 2019

Fix is officially released, you can update ngx-markdown to v7.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior
Projects
None yet
Development

No branches or pull requests

2 participants