Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LaTeX support #181

Closed
DomiDre opened this issue Oct 6, 2019 · 2 comments
Closed

Add LaTeX support #181

DomiDre opened this issue Oct 6, 2019 · 2 comments
Labels
enhancement Improvement request

Comments

@DomiDre
Copy link
Contributor

DomiDre commented Oct 6, 2019

I would love to also use some simple LaTeX within my markdown texts (to include some formulas in a post for example). I saw #68 but that got closed... and I found the package ngx-markdown-katex ( https://www.npmjs.com/package/ngx-markdown-katex ) which however is missing some features from ngx-markdown...

So... is there some specific reasons to avoid including katex optionally?

@jfcere
Copy link
Owner

jfcere commented Oct 7, 2019

Hi @DomiDre, thanks for your PR!

There is not specific reason not to include katex... I just never add the time to look deeper in its integration but I am glad you did it.

I will merge your PR but I will need to make some changes before to release it and fix failing tests.

This should be release during the week.

@jfcere jfcere added the enhancement Improvement request label Oct 7, 2019
@jfcere
Copy link
Owner

jfcere commented Oct 8, 2019

Katex support is now live 🎉
Thanks again for you contribution @DomiDre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement request
Projects
None yet
Development

No branches or pull requests

2 participants