Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'ErrorObservable' is not generic. #4

Closed
kerrongordon opened this issue Feb 21, 2017 · 5 comments
Closed

Type 'ErrorObservable' is not generic. #4

kerrongordon opened this issue Feb 21, 2017 · 5 comments

Comments

@kerrongordon
Copy link

kerrongordon commented Feb 21, 2017

ERROR
node_modules/ng2-markdown-to-html/src/app/markdown-to-html/markdown-to-html.service.ts (25,39): Type 'ErrorObservable' is not generic.)

i am getting this error with @angular/cli 1.0.0-beta.32.3
while using the ng build -prod --aot --verbose

@jfcere
Copy link
Owner

jfcere commented Feb 22, 2017

I'll update angular-cli .. I'll come back to you!

@pmcalabrese
Copy link

pmcalabrese commented Feb 22, 2017

same here... when i compile with --aot

[EDIT]
One quick fix (just for releasing) would be comment out in the file markdown-to-html.service.ts the line with ErrorObservable (line 4)
and remove type definition which is really not necessary because implicit on the handError method (line 25)

import { Injectable } from '@angular/core';
import { Http, Response } from '@angular/http';
import { Observable } from 'rxjs/Observable';
// import { ErrorObservable } from 'rxjs/observable/ErrorObservable';

from

handleError(error: Response | any): ErrorObservable<string> {

to

handleError(error: Response | any) {

@jfcere
Copy link
Owner

jfcere commented Feb 22, 2017

@pmcalabrese Thx for the insight i'll make the fix tonight

@jfcere jfcere closed this as completed Feb 22, 2017
@jfcere jfcere reopened this Feb 22, 2017
@pmcalabrese
Copy link

@jfcere no problem 👍

@jfcere
Copy link
Owner

jfcere commented Feb 23, 2017

I updated Angular-CLI to 1.0.0-beta.32.3 and solved the typing error when compiling with AoT.
Please upgrade to version 0.0.9 to get the fix.

I'll close the issue, don't hesitate to reopen if there is anything!

@jfcere jfcere closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants