Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rxjs 6 #57

Closed
yashsriv opened this issue Apr 11, 2018 · 5 comments
Closed

Support for rxjs 6 #57

yashsriv opened this issue Apr 11, 2018 · 5 comments

Comments

@yashsriv
Copy link

Angular 6 uses rxjs 6 which doesn't have deep imports supported.

@jfcere
Copy link
Owner

jfcere commented Apr 11, 2018

@yashsriv thanks for the notice, i'll add this as a note to myself:

https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#breaking-changes-6
deep imports: Can no longer deep import top-level types such as rxjs/Observable, rxjs/Subject, rxjs/ReplaySubject, et al. All imports should be done directly from rxjs, for example: import { Observable, Subject } from 'rxjs';

@jfcere
Copy link
Owner

jfcere commented May 4, 2018

Now that Angular 6 is officially released I am going to do the modifications this weekend.

@rgwood
Copy link

rgwood commented May 4, 2018

Thanks for looking at this so quickly after Angular 6's release.

I've found this article useful for upgrading from RxJS 5 to 6: https://auth0.com/blog/whats-new-in-rxjs-6/

@jfcere
Copy link
Owner

jfcere commented May 4, 2018

@rgwood thx for the article, i'll look into it!

@jfcere jfcere mentioned this issue May 7, 2018
7 tasks
@jfcere
Copy link
Owner

jfcere commented May 7, 2018

Update to Angular 6 has been published in v1.6.0.

@jfcere jfcere closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants