Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to understand your semver choice of 1.6 #72

Closed
EMCP opened this issue May 25, 2018 · 3 comments
Closed

Trying to understand your semver choice of 1.6 #72

EMCP opened this issue May 25, 2018 · 3 comments
Labels
question Issue representing a how-to question

Comments

@EMCP
Copy link

EMCP commented May 25, 2018

version 1.6 seems to completely break some applications.. sounds like I should never use ^ in front of ngx-markdown and freeze at 1.5.2 until I can bring the app up to angular 6.. but shouldn't this have been a 2.0.0 release?

@jfcere
Copy link
Owner

jfcere commented May 25, 2018

Nothing to understand ... bad move, shit happens!
Still I apologize for any problem this could cause.

My recommendation right now would be to set the dependcy to ~1.5.0 to stay withing the 1.5.x range if you are not yet on Angular 6.

"ngx-markdown": "~1.5.0"

Now I would probaby feel bad to "unpublish" the v1.6.0 because it would break thoses who already switched. But still, this is something I am considering as I will release 2.0 soon anyway. Maybe deprecate with an explicit warning?

@jfcere jfcere added the question Issue representing a how-to question label May 25, 2018
@EMCP
Copy link
Author

EMCP commented May 25, 2018

All the same, thanks for the library. Will use ~. We seem to have recovered safely.

@EMCP EMCP closed this as completed May 25, 2018
@ganeshkbhat
Copy link

ganeshkbhat commented May 26, 2018

I saw that. and it works fine with 6.0.0 which was mentioned in the readme notes. So no issues. Its a fantastic library which can give lots a run for their projects. Cheers @jfcere .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue representing a how-to question
Projects
None yet
Development

No branches or pull requests

3 participants