Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-12 #7

Closed
jfcherng opened this issue Aug 11, 2019 · 1 comment
Closed

PSR-12 #7

jfcherng opened this issue Aug 11, 2019 · 1 comment
Assignees
@jfcherng
Labels
coding style Coding style problem

Comments

@jfcherng
Copy link
Owner

jfcherng commented Aug 11, 2019 •
edited

https://github.com/jfcherng/php-diff/tree/psr-12 Just to prevent from being forgotten.

Previously in PSR-2, the major "problem" is about the cs of multiline conditioning. PSR-12 has made it more clear and friendly.

May try <rule ref="PSR12"/> when php_codesniffer reaches 3.5.0.
@jfcherng jfcherng added the coding style Coding style problem label Aug 11, 2019
@jfcherng jfcherng self-assigned this Aug 11, 2019
@jfcherng
Copy link
Owner Author

jfcherng commented Sep 30, 2019 •
edited

Done in 896df76.

Just a context separator. 2
B
Donec rutrum test.
There is a new inserted line.
C
gravida aliquet test.
Sed dictum test.

@jfcherng jfcherng changed the title PSR-12 has been accepted PSR-12 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfcherng jfcherng

Labels
coding style Coding style problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfcherng