Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion limit warning encountered too often #138

Open
jfecher opened this issue Oct 6, 2022 · 0 comments
Open

Recursion limit warning encountered too often #138

jfecher opened this issue Oct 6, 2022 · 0 comments

Comments

@jfecher
Copy link
Owner

jfecher commented Oct 6, 2022

867cfea caused us to try constraints earlier and retry if they fail, which lead to more constraints hitting the recursion limit and issuing a warning before retrying later and succeeding.

The retry behavior is not a bug but the trait solver should be smarter about its impl search such that it either can detect infinite recursion before resorting to the recursion counter (current limit is 10 recursive calls) or the warning should be forever silenced, along with a possible lowering of the recursion limit (to 5? 7?*) since it affects the speed of the trait solver much more now.

The warning has been temporarily disabled for the time being by the same commit.

  • 7 or even 5 recursive traits should be sufficient to solve most programs, but one can always construct a trait that requires > 5 given constraints deep. Uncertain as to how common this may be in highly generic libraries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant