Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proper error message for unhandled effects #171

Open
jfecher opened this issue Dec 8, 2023 · 0 comments
Open

Add a proper error message for unhandled effects #171

jfecher opened this issue Dec 8, 2023 · 0 comments
Labels
error reporting For issues related to error message quality or the reporting of diagnostics in general good first issue An issue that doesn't require deep knowledge of the compiler to fix or implement type system For issues related to Ante's type system

Comments

@jfecher
Copy link
Owner

jfecher commented Dec 8, 2023

Currently if there are unhandled effects that percolate up to top-level the compiler will fail an assert and panic. To fix this, a proper error message should be issued to inform the user of the unhandled effects (ideally with the original locations of these effects).

See https://github.com/jfecher/ante/blob/master/src/types/typechecker.rs#L1448

E.g.

simple.an:6:1  error: Unhandled effect `Throw Unit`
throw ()
@jfecher jfecher added good first issue An issue that doesn't require deep knowledge of the compiler to fix or implement type system For issues related to Ante's type system error reporting For issues related to error message quality or the reporting of diagnostics in general labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error reporting For issues related to error message quality or the reporting of diagnostics in general good first issue An issue that doesn't require deep knowledge of the compiler to fix or implement type system For issues related to Ante's type system
Projects
None yet
Development

No branches or pull requests

1 participant