fix: surface the message when the check api returns an error #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmenendez
changed the title
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 52.81% 52.79% -0.02%
==========================================
Files 18 18
Lines 320 322 +2
Branches 43 44 +1
==========================================
+ Hits 169 170 +1
- Misses 134 135 +1
Partials 17 17
Continue to review full report at Codecov.
|
machour
requested changes
Feb 21, 2018
There was a problem hiding this comment.
Hey @davidmenendez and thank you for this proposal.
Left you a small feedback to address!
src/util/check.js
Outdated
| @@ -25,6 +25,9 @@ function getContributorsPage(url) { | |||
| }) | |||
| .then(res => { | |||
| const body = JSON.parse(res.body) | |||
| if (res.statusCode !== 200) { | |||
There was a problem hiding this comment.
30x are also valid API response code (https://developer.github.com/v3/#http-redirects)
|
good point! |
machour
changed the title
machour
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If the contributors API returns a bad response show the error message
Why:
I ran into this when I was running the check command. The CLI was throwing an error on this line https://github.com/jfmengels/all-contributors-cli/blob/master/src/util/check.js#L28 the response from the API was a 403 and I was getting rate limited. The response was something like
but there's no prior check to see if either the response is a 200 or if the body is an array. I think it makes sense to throw an error and tell the user what's happening.
How:
Updated the code to throw an error if the API response isn't 200.
Checklist: