Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Encrypted Password #54

Open
marcandre-larochelle-bell opened this issue Feb 14, 2023 · 0 comments
Open

Support Encrypted Password #54

marcandre-larochelle-bell opened this issue Feb 14, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@marcandre-larochelle-bell
Copy link

marcandre-larochelle-bell commented Feb 14, 2023

Is your feature request related to a problem? Please describe.

This is a security enhancement request and follows the way other official plugins do it.

Describe the solution you'd like to see

Enable specifying the server.id to read from for the credentials (username and password)

In settings.xml:

<settings>
  ...
  <servers>
    <server>
      <id>artifactory</id>
      <username>username</username>
      <password>encrypted_password</password>
    </server>
  </servers>
  ...
</settings>

In artifactory-maven-plugin:

<publisher>
  <contextUrl>https://artifactory.int.bell.ca:443/artifactory</contextUrl>
  <serverCredentials>artifactory</serverCredentials>
</publisher>

The property from the artifactory-maven-plugin must match the server id found in the settings.xml.

Documentation on Maven Password Encryption:

Examples of how other official plugins do it:

How sql-maven-plugin reads the settings:

Describe alternatives you've considered

Access tokens, but it is still stored in plain text in the settings.xml or pom.xml.

Additional context

No response

@marcandre-larochelle-bell marcandre-larochelle-bell added the feature request New feature or request label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant