Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores nonProxyHosts from settings.xml #65

Open
TobiX opened this issue Apr 2, 2023 · 1 comment
Open

Ignores nonProxyHosts from settings.xml #65

TobiX opened this issue Apr 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@TobiX
Copy link

TobiX commented Apr 2, 2023

Describe the bug

The proxy support merged with #64 and included in release 3.6.0 ignores the <nonProxyHosts> setting from settings.xml

Current behavior

Plugin does not consider proxy exceptions when connecting to Artifactory.

Reproduction steps

  1. Consider this settings in Maven's settings.xml:
    <proxy>
      <active>true</active>
      <protocol>http</protocol>
      <host>proxy.corp.bogus</host>
      <port>80</port>
      <nonProxyHosts>localhost*|127.0.0.1|*.corp.bogus</nonProxyHosts>
    </proxy>
  1. Try to reach an Artifactory server at artifactory.corp.bogus
  2. The plugin tries to connect to the Artifactory server through the proxy and fails

Expected behavior

Plugin should consider proxy exceptions when connecting to Artifactory.

Artifactory Maven plugin version

3.6.0

Operating system type and version

N/A

JFrog Artifactory version

No response

Maven version

3.9.1

@TobiX TobiX added the bug Something isn't working label Apr 2, 2023
@lfvjimisola
Copy link

lfvjimisola commented Sep 5, 2023

We have the same issue with the plugin due to the fact that is does not handle nonProxyHosts in settings.xml in setupProxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants