-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use force_revocable tokens in 7.50.3+ #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have 2 minor nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, as is, but I think we could design the "version check" stuff better. I'd like to make it so that the version is detected once at config time, then maybe during "reload" ? Then we could switch the "checks" to just compare the version from config.
b8dd8a4
to
d200fbc
Compare
Fixed spelling on |
d200fbc
to
598e6e2
Compare
Sorry, I just noticed my "Makefile" fix for |
@alexhung While doing the UserTemplate stuff, I think I might have made an error around the TTL. I assume that the role maxTTL was the number to use, but now I see there is more TTL related logic in the EDIT: I think the easiest way to handle this will be to modify the role.MaxTTL that gets sent to the createToken function, in the event that there is a system level setting limiting maxTTL. That way we don't have to change the "interface" to createToken, and we don't have to mess with trying to move any logic around or parse/return any TTL values. EDIT: FIXED, as per above, just set role.MaxTTL instead of keeping that as a local variable, which makes the original code still work, but respect the system level MaxLeaseTTL |
749ad6e
to
ae1a1a9
Compare
UPDATE: Rebased (one commit) and pulled out the magic version stuff... as I found it it fails after a reload. I need to sort out initialize, which I will do as part of a separate MR. Let's keep this one simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This enables setting the
force_revocable
flag and set andexpires_in
to MaxTLLFixes #40