Artifactory nodeSelector, affinity and tolerations seem to be indented wrongly

[mbraku]

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
Helm
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

Kubernetes
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-12T14:26:04Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:34:22Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
Artifactory

What happened:
Error: release artifactory-v6 failed: StatefulSet in version "v1beta2" cannot be handled as a StatefulSet: v1beta2.StatefulSet.Spec: v1beta2.StatefulSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.NodeSelector: ReadString: expects " or n, but found {, error found in #10 byte of ...|ssProbe":{"failureTh|..., bigger context ...|:"wait-for-db"}],"nodeSelector":{"livenessProbe":{"failureThreshold":10,"httpGet":{"path":"/artifact|...

What you expected to happen:
The installation would be successful and the nodeSelector, affinity or tolerations are set

How to reproduce it (as minimally and precisely as possible):
Try to install the artifactory chart while specifying a nodeSelector, affinity or tolerations

values.yaml:

artifactory:
  nodeSelector:
    type: "artifactory"

Anything else we need to know:
Compare

charts/stable/artifactory/templates/artifactory-statefulset.yaml

Line 166 in 44221cf

nodeSelector:

with

charts/stable/distribution/templates/distribution-statefulset.yaml

Line 120 in 44221cf

{{ toYaml .Values.distribution.resources | indent 10 }}

or

charts/stable/distribution/templates/distributor-statefulset.yaml

Line 96 in 44221cf

{{ toYaml .Values.distributor.resources | indent 10 }}

[eldada]

@mbraku - seems like you actually found a bug in other charts 😉. The indent in artifactory seems right.
As for your error, I'm not sure it's related to the indent. I think the location of the nodeSelector in the yaml is wrong. I'm looking into it.

[eldada]

@mbraku - can you confirm that pull request #119 fixes your issue?
I'll fix other charts in separate PRs.

[mbraku]

Yes, it works now after pulling the new master. Thanks for the quick fix 👍