Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing quote for ingress host names in all charts #71

Closed
sebastien-prudhomme opened this issue Oct 9, 2018 · 0 comments · Fixed by #72
Closed

Missing quote for ingress host names in all charts #71

sebastien-prudhomme opened this issue Oct 9, 2018 · 0 comments · Fixed by #72

Comments

@sebastien-prudhomme
Copy link
Contributor

sebastien-prudhomme commented Oct 9, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

BUG REPORT
Version of Helm and Kubernetes:

Which chart:

All charts

What happened:

Charts are not compatible with ingres hosts names begining with '*', Helm complains about syntax

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Ingress host names should be quoted like this:

  {{- range $host := .Values.ingress.hosts }}
  - host: {{ $host | quote }}

See how the ingress template is created with "helm create" command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant