Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check for administrative access by locking for group name. #7

Closed
kmpm opened this issue Oct 9, 2012 · 1 comment
Closed

Do not check for administrative access by locking for group name. #7

kmpm opened this issue Oct 9, 2012 · 1 comment

Comments

@kmpm
Copy link

kmpm commented Oct 9, 2012

If Windows run in another language then English the group will be called differently.
Please check for SID instead of group name. S-1-5-32-544 is the local Administrators group.

Well-know security identifiers
http://support.microsoft.com/kb/243330
@jfromaniello
Copy link
Owner

Thanks @kmpm , fixed and deployed to npm as versión 0.0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmpm @jfromaniello